[PAL/vm-common] Get memory regions from VMM using "etc/e820" fw_cfg file #28
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion
a discussion (no related file):
Blocking: must test and understand all reserved ranges on new QEMU/on different environments.
dimakuv
force-pushed
the
dimakuv/parse-etc-e820-fwcfg-file
branch
from
a6cba2d
to
fb38207
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, all discussions resolved
a discussion (no related file):
Previously, dimakuv (Dmitrii Kuvaiskii) wrote…
Blocking: must test and understand all reserved ranges on new QEMU/on different environments.
Update: the problem was not related to some new reserved memory ranges on newer QEMU (v8.0).
The root cause was that docker run ... by default sets 64MB of /dev/shm. As soon as I set this limit to the one used by Gramine VMs, it started working: e.g. docker run --shm-size 4G.
Previously on the VM PAL, we hard-coded a single memory region that is RAM (i.e., not reserved) via `FW_CFG_RAM_SIZE`. This is a dangerous assumption which may break in the future. This commit uses a proper source of E820 info: the `etc/e820` fw_cfg file. As a side effect, `find_fw_cfg_selector()` function was slightly modified to also return the size of the object. All callers of this function now use this returned size. Signed-off-by: Dmitrii Kuvaiskii <dmitrii.kuvaiskii@intel.com>
dimakuv
force-pushed
the
dimakuv/parse-etc-e820-fwcfg-file
branch
from
fb38207
to
0e8293d
Compare
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Description of the changes
Previously on the VM PAL, we hard-coded a single memory region that is RAM (i.e., not reserved) via
FW_CFG_RAM_SIZE. This is a dangerous assumption which may break in the future. This commit uses a proper source of E820 info: theetc/e820fw_cfg file.As a side effect,
find_fw_cfg_selector()function was slightly modified to also return the size of the object. All callers of this function now use this returned size.Fixes #27.
How to test this PR?
Run on newer QEMU.
This change is